> On Feb. 12, 2018, 1:13 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 706-708 (patched) > > <https://reviews.apache.org/r/63368/diff/4/?file=1953408#file1953408line706> > > > > Why this is not a simple delay? To indicate that a profiling session is > > running?
It would be possible to implement the same without having the `profilingTimer` (the only change being that the remaining time cannot be displayed), but binding that piece of state to a member variable seems more inuitive to me than having it implicit. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197256 ----------------------------------------------------------- On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63368/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2018, 10:41 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This class exposes profiling functionality of jemalloc memory allocator > when it is detected to be the memory allocator of the current process. > > In particular, it gives developers an easy method to collect and > access heap profiles which report which pieces of code were > responsible for allocating memory. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c895d3ac7b9cc5ffd6c8b57ff24def866eb0213d > 3rdparty/libprocess/include/process/memory_profiler.hpp PRE-CREATION > 3rdparty/libprocess/include/process/process.hpp > 8661706cb058efb26f5bfbcc84972f9930d3670f > 3rdparty/libprocess/src/CMakeLists.txt > 0ce7dac5deea94623530820d173ce3ffe5b42ea4 > 3rdparty/libprocess/src/memory_profiler.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 42e7adf740b234ebf23d2dcb71440749c0ed87ec > > > Diff: https://reviews.apache.org/r/63368/diff/6/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >