-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/#review197344
-----------------------------------------------------------




src/tests/containerizer/docker_common.hpp
Lines 126 (patched)
<https://reviews.apache.org/r/65615/#comment277475>

    `status()->get()`



src/tests/containerizer/docker_common.hpp
Lines 163 (patched)
<https://reviews.apache.org/r/65615/#comment277476>

    Ditto. Avoid chained .get()s.


- Andrew Schwartzmeyer


On Feb. 12, 2018, 4:22 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65615/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2018, 4:22 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch is in preparation of porting docker tests to Windows. There
> were a few hardcoded values that were used throughout the codebase,
> such as the `alpine` image, that are defined as a constant in a single
> file.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_common.hpp PRE-CREATION 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> d1e657050d623ad0412208b3aa3e3101e3654e99 
>   src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d 
>   src/tests/mesos.hpp c5593c25dde18c005f195a1885a8586bc72c849f 
> 
> 
> Diff: https://reviews.apache.org/r/65615/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Reply via email to