> On Feb. 22, 2018, 3:25 a.m., Alexander Rukletsov wrote:
> > src/Makefile.am
> > Lines 1276 (patched)
> > <https://reviews.apache.org/r/65615/diff/3/?file=1963325#file1963325line1276>
> >
> >     What about CMake?

Headers are free in CMake.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/#review198108
-----------------------------------------------------------


On Feb. 21, 2018, 5:47 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65615/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2018, 5:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch is in preparation of porting docker tests to Windows. There
> were a few hardcoded values that were used throughout the codebase,
> such as the `alpine` image, that are defined as a constant in a single
> file.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
>   src/tests/containerizer/docker_common.hpp PRE-CREATION 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 97335e197fb0fcb5caa06d8cea4a57277d2cf1f3 
>   src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 
>   src/tests/mesos.hpp 1416682fc8b51d38adc02d549a81fd0b09c83fa9 
> 
> 
> Diff: https://reviews.apache.org/r/65615/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Reply via email to