----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/#review198108 -----------------------------------------------------------
To simplify reviewing, in the future please separate refactoring and moving stuff around from actual changes. src/Makefile.am Lines 1276 (patched) <https://reviews.apache.org/r/65615/#comment278216> What about CMake? - Alexander Rukletsov On Feb. 22, 2018, 1:47 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65615/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 1:47 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, and Joseph Wu. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > This patch is in preparation of porting docker tests to Windows. There > were a few hardcoded values that were used throughout the codebase, > such as the `alpine` image, that are defined as a constant in a single > file. > > > Diffs > ----- > > src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 > src/tests/containerizer/docker_common.hpp PRE-CREATION > src/tests/containerizer/docker_containerizer_tests.cpp > 97335e197fb0fcb5caa06d8cea4a57277d2cf1f3 > src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab > src/tests/mesos.hpp 1416682fc8b51d38adc02d549a81fd0b09c83fa9 > > > Diff: https://reviews.apache.org/r/65615/diff/3/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
