-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65774/#review198245
-----------------------------------------------------------




src/master/master.hpp
Lines 2281-2285 (patched)
<https://reviews.apache.org/r/65774/#comment278350>

    Now that I'm looking at the other methods in the Framework struct, I don't 
love that we're sending to subscribers here :-/
    
    The only other use of the `master` member is to send messages to the 
framework itself. This new code entangles the Framework struct a bit more with 
unrelated master state, which perhaps isn't great.
    
    I think this will work as a short-term solution, but maybe we can come up 
with something later on which will move this block back into 'master.cpp'.


- Greg Mann


On Feb. 23, 2018, 8:08 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65774/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2018, 8:08 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jan Schlicht, Vinod Kone, and Jiang Yan 
> Xu.
> 
> 
> Bugs: MESOS-8601
>     https://issues.apache.org/jira/browse/MESOS-8601
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the master fails over and a client subscribes to the master before
> agent re-registration, the master will crash when sending `TASK_ADDED`
> because the framework info might not have been added to the master yet.
> This patch fixes this bug.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 6569c9ea0677f193ec56c276e6deea3f2fe86514 
>   src/master/master.cpp e7d5ac67a94f927bb747bd283a3bf9671b2b8f44 
> 
> 
> Diff: https://reviews.apache.org/r/65774/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Reply via email to