----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198249 -----------------------------------------------------------
Patch looks great! Reviews applied: [64226] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Dec. 1, 2017, 3:46 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64226/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 3:46 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-8284 > https://issues.apache.org/jira/browse/MESOS-8284 > > > Repository: mesos > > > Description > ------- > > Added a `ns::supported` convenience API which directly expresses the > intent to probe whether a specific Linux namespace is supported on > the running kernel and takes care of kernel versioning special cases. > > This API subsumes the previous usages of `ns::namespaces`, so that API > is now used only retained as an internal helper. > > > Diffs > ----- > > src/linux/ns.hpp 8b6406754340d5bc244047a9d8c9fad5cead8f4d > src/linux/ns.cpp 49f8fca5884da7425f2fed5e8b598ef7cc4dc6e1 > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > 90773d7b237ac83899d161ab251b4eecda02b3b9 > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > d765929c2d5133ad5eac9f8a6c4d68ceda922eea > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e > src/tests/containerizer/ns_tests.cpp > 61adf8525b1df1a70d7fd9c747d2106630a7627d > src/tests/containerizer/setns_test_helper.cpp > 045caf684baf6e724fa5f99b6cc3feeb87817ba3 > > > Diff: https://reviews.apache.org/r/64226/diff/6/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
