> On Feb. 24, 2018, 11:08 a.m., Benjamin Bannier wrote:
> > I think a sticky issue which would have been great to resolve here is to 
> > make sure that we enable building of endpoint documentation generation for 
> > non-dockerized site builds as well (i.e., `cd site/ && bundle install && 
> > bundle exec rake` should produce output similar to what the dockerized 
> > version running in CI produces; this probably requires adding a dedicated 
> > rake targe). Granted, this was already slightly broken, and we now make 
> > that more apparent.

Yeah sounds great for a follow up (perhaps we need instructions on how to 
generate the help endpoints when using that method in the short term rather 
than automating it?). We had discussed it but treated it as an orthogonal issue 
that was already broken (as you said, might as well make it clear that the 
docs/ folder has 2 year old stale http endpoint docs).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65791/#review198252
-----------------------------------------------------------


On Feb. 24, 2018, 12:29 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65791/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2018, 12:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Bugs: MESOS-8442
>     https://issues.apache.org/jira/browse/MESOS-8442
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is now generated by the website CI bot, rather than having
> to be checked in and kept up to date within the docs/ folder.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/files/browse.json.md 
> 6b21e50bb0c0098babedcd612a5acfd0e6ae0aab 
>   docs/endpoints/files/browse.md 0fa204a85fc62aa4b43dacc07aec6951b618a015 
>   docs/endpoints/files/debug.json.md 2806a5844f49a3c051e58db0723879c9627e18e1 
>   docs/endpoints/files/debug.md 33380663eab59c704c610bd392676aee99528f77 
>   docs/endpoints/files/download.json.md 
> 31d442a7e1e3d4c6e32986ec85e42f3364f37de9 
>   docs/endpoints/files/download.md 202d015484b22e63c9d24610808a43d091786844 
>   docs/endpoints/files/read.json.md 64f348e76d61d3d0ad364f4712d3c1d90818d6d1 
>   docs/endpoints/files/read.md ef95c80739eeb09f52658470429c6ffb9b41fb8c 
>   docs/endpoints/index.md 871153774c4b21cdca4afec9bc2ce2bd955b17c4 
>   docs/endpoints/logging/toggle.md 014a1969a7efb709e06c0c90ca023f2fa747414e 
>   docs/endpoints/master/api/v1.md 2d778f33c830caccb0254cf15adc46a86b5db48a 
>   docs/endpoints/master/api/v1/scheduler.md 
> f029d8e6e90bc7d974d60ad4a71d63807f0e901a 
>   docs/endpoints/master/create-volumes.md 
> c9ce39ead8041f249ee6f85d1afdd8f90b38ce9b 
>   docs/endpoints/master/destroy-volumes.md 
> ff82e96a6ee1e9f6e1bbc565ab40c98b758c1227 
>   docs/endpoints/master/flags.md 6b3de41d45278cc34a4f4f0e52b76407ab96b790 
>   docs/endpoints/master/frameworks.md 
> 7aa22130dfa8702d8b93690cb75f1323ea3c2223 
>   docs/endpoints/master/health.md 3752a1bb4a9a7c2cc5cbf25b021592280c174a80 
>   docs/endpoints/master/machine/down.md 
> 05abd155e693163eb50f675d2724534a6f87dfba 
>   docs/endpoints/master/machine/up.md 
> 8a3488bb3f96bc7470aaea5114559cb593cbb3a8 
>   docs/endpoints/master/maintenance/schedule.md 
> 86ae30b06118f13593e91b70dbec97945b1d9bd8 
>   docs/endpoints/master/maintenance/status.md 
> f8e1c7eed44e14a8324b582a2db91e523b2fbc15 
>   docs/endpoints/master/quota.md 6ce7811136ac1c4ae00a3011dca17cbde948f14e 
>   docs/endpoints/master/redirect.md 3c568e3eef658f9a489008f4f84745827f8002f0 
>   docs/endpoints/master/reserve.md 8174027f0e66dc4e9ae7bca951ed9ca38033008d 
>   docs/endpoints/master/roles.json.md 
> 9acba2cfed120918b2571d7336eeee651d125cbe 
>   docs/endpoints/master/roles.md de58120172c390ef1f084031077fd9b865b817db 
>   docs/endpoints/master/slaves.md 9365cdb9e5b17cdf26ed38a0ab1fff8afef38f00 
>   docs/endpoints/master/state-summary.md 
> 21b8703bb011daf5cc560550e6c2ce36ba615bba 
>   docs/endpoints/master/state.json.md 
> 62a723051270ab24591b956805aee5455848201b 
>   docs/endpoints/master/state.md 09a478263d4cd015040f47619b0aa94341c3bba2 
>   docs/endpoints/master/tasks.json.md 
> f9553d7bde7de33b02795ba9088a88e68cb2a0cc 
>   docs/endpoints/master/tasks.md 019a14bb6c8d8acd3aab4a1f7ba6893f4bad835b 
>   docs/endpoints/master/teardown.md b017084e3d195363615a59011671fdbd76182a1a 
>   docs/endpoints/master/unreserve.md 324dcded2013aeb6c167a695bbad1da69340cd57 
>   docs/endpoints/master/weights.md 3c9019e74867cbd931dc5c68a0d8de3ea269e5b2 
>   docs/endpoints/metrics/snapshot.md 0912fa939b38fd1d83aaaa35e165c7aeddf1f076 
>   docs/endpoints/profiler/start.md a25f0d0468f2ad9f8d1ff41f6c50ea0bbe87d316 
>   docs/endpoints/profiler/stop.md 5028d13f8a3f9aa3d41b60959a9cc3d6b03fb7d9 
>   docs/endpoints/registrar/registry.md 
> e347db269839d60fac6de0777b245e830279661e 
>   docs/endpoints/slave/api/v1.md b394f7fac2c4600b7e11f5c7f4def44edc22e7db 
>   docs/endpoints/slave/api/v1/executor.md 
> 5ef40e3ca5ad072b5bbfd480d4e0b56d9530a17f 
>   docs/endpoints/slave/api/v1/resource_provider.md 
> c721c6d005224807bdb4fbfcf4fd7c30edb82e6c 
>   docs/endpoints/slave/containers.md f8bcb3847a6e29dc98d424cdfeacfce26ad98d67 
>   docs/endpoints/slave/flags.md 4a8a0361124078342887c291acaa73c9f6f4bc4d 
>   docs/endpoints/slave/health.md 988567cdbe885dbfe1270732f84e529b13983546 
>   docs/endpoints/slave/monitor/statistics.json.md 
> 51d7c39ff994aeabf0bb805a087e8d0f8c85c818 
>   docs/endpoints/slave/monitor/statistics.md 
> 342638f028885c7c27a76ccea3213567f64731dd 
>   docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded 
>   docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b 
>   docs/endpoints/system/stats.json.md 
> 87e470aa9d29af4ee0e62d7a6d5561e784ef8818 
>   docs/endpoints/version.md 4f5db22baef76a499a657745f1275ecd97bffbcd 
> 
> 
> Diff: https://reviews.apache.org/r/65791/diff/1/
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Reply via email to