> On Feb. 27, 2018, 5:42 p.m., Zhitao Li wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 61 (patched) > > <https://reviews.apache.org/r/65811/diff/1/?file=1965810#file1965810line61> > > > > Can you clarify whether the rules also apply to windows properly with > > correct separator?
Mostly it's about how to deal with the drive part of Windows pathnames. There is code within the same file that I can share, but I intend to do it later (marked with a TODO). > On Feb. 27, 2018, 5:42 p.m., Zhitao Li wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 85 (patched) > > <https://reviews.apache.org/r/65811/diff/1/?file=1965810#file1965810line85> > > > > I don't think c++ vector supports negative index (this is not python). > > > > You can use `components.back()` as long as `components` is guaranteed > > not empty. Doh! This was dumb. Nice catch! - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review198334 ----------------------------------------------------------- On Feb. 27, 2018, 6:52 p.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65811/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2018, 6:52 p.m.) > > > Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, > James Peach, and Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Add `path::clean` to stout for normalizing path (for POSIX only now). > > > Diffs > ----- > > 3rdparty/stout/include/stout/path.hpp > 27438d31617b3b78bf3d4deffd25c93340610e8d > > > Diff: https://reviews.apache.org/r/65811/diff/2/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
