> On March 2, 2018, 8:06 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 65 (patched) > > <https://reviews.apache.org/r/65811/diff/3/?file=1969142#file1969142line65> > > > > How about s/clean/normalize/?
Indeed I considered this option. And I also considered `normpath` as in `os.path.normpath` in Python but ended up picking `path::clean` from the Go counterpart (`filepath.Clean`) over `path::normalize`. That said, I'm open to `path::normalize` if we have more folks in favor of it. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review198548 ----------------------------------------------------------- On March 2, 2018, 7:40 p.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65811/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 7:40 p.m.) > > > Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, > James Peach, and Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Add `path::clean` to stout for normalizing path (for POSIX only now). > > > Diffs > ----- > > 3rdparty/stout/include/stout/path.hpp > 27438d31617b3b78bf3d4deffd25c93340610e8d > > > Diff: https://reviews.apache.org/r/65811/diff/3/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
