> On March 16, 2018, 11:17 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 65 (patched) > > <https://reviews.apache.org/r/65811/diff/3/?file=1969142#file1969142line65> > > > > Can you add some tests for this? This warrents some tests. Also, please > > reach out to Andrew because this will also compile (maybe used) on windows.
if it's posix only for now, please move to posix only headers, or add an assertion failure if this method is used on windows. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review199363 ----------------------------------------------------------- On March 2, 2018, 7:40 p.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65811/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 7:40 p.m.) > > > Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, > James Peach, and Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Add `path::clean` to stout for normalizing path (for POSIX only now). > > > Diffs > ----- > > 3rdparty/stout/include/stout/path.hpp > 27438d31617b3b78bf3d4deffd25c93340610e8d > > > Diff: https://reviews.apache.org/r/65811/diff/3/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
