----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65311/#review198811 -----------------------------------------------------------
src/common/http.hpp Lines 215-220 (patched) <https://reviews.apache.org/r/65311/#comment279056> Looks like we'll end up logging an extra space when `principal.isNone()`. src/common/http.hpp Lines 244 (patched) <https://reviews.apache.org/r/65311/#comment279103> Could you verify that this is true in the case of resource-provider-capable agents? See https://github.com/apache/mesos/blob/66bae088de61ae0cc3f9c5fac6f4b6f9695a27d1/src/master/master.cpp#L7087-L7117 I haven't yet identified code in the agent which downgrades resources before checkpointing. src/common/http.cpp Lines 874 (patched) <https://reviews.apache.org/r/65311/#comment279104> Indented too far. src/common/http.cpp Lines 894 (patched) <https://reviews.apache.org/r/65311/#comment279105> Should we use an underscore for this `approvers` variable? - Greg Mann On Feb. 5, 2018, 1:52 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65311/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2018, 1:52 p.m.) > > > Review request for mesos, Benjamin Hindman and Greg Mann. > > > Bugs: MESOS-8434 > https://issues.apache.org/jira/browse/MESOS-8434 > > > Repository: mesos > > > Description > ------- > > Introduces the class `ObjectApprovers` which unifies the different > mechanisms used in Mesos in order to perform authorization. > > This new class will supersede the `Acceptor` interfaces and their > logic. > > Follow up patches will make use of this interface and remove > deprecated code. > > > Diffs > ----- > > src/common/http.hpp 750d3bfba1647624983108bdd23295a3b3091fe4 > src/common/http.cpp 8d3a4ad63bd74e0313082bad3d89c21fbf54f256 > > > Diff: https://reviews.apache.org/r/65311/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
