> On March 8, 2018, 5:24 a.m., Greg Mann wrote: > > src/common/http.hpp > > Lines 244 (patched) > > <https://reviews.apache.org/r/65311/diff/5/?file=1965885#file1965885line244> > > > > Could you verify that this is true in the case of > > resource-provider-capable agents? See > > https://github.com/apache/mesos/blob/66bae088de61ae0cc3f9c5fac6f4b6f9695a27d1/src/master/master.cpp#L7087-L7117 > > > > I haven't yet identified code in the agent which downgrades resources > > before checkpointing.
The code was introduced in [r/61171/](https://reviews.apache.org/r/61171/) and we discussed that thoroughly there. However, removing this if doesn't seem to cause any change in the tests so now I am wondering whether we need it at all. I think the best course of action is to keep it and investigate further whether it is necessary. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65311/#review198811 ----------------------------------------------------------- On Feb. 5, 2018, 2:52 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65311/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2018, 2:52 p.m.) > > > Review request for mesos, Benjamin Hindman and Greg Mann. > > > Bugs: MESOS-8434 > https://issues.apache.org/jira/browse/MESOS-8434 > > > Repository: mesos > > > Description > ------- > > Introduces the class `ObjectApprovers` which unifies the different > mechanisms used in Mesos in order to perform authorization. > > This new class will supersede the `Acceptor` interfaces and their > logic. > > Follow up patches will make use of this interface and remove > deprecated code. > > > Diffs > ----- > > src/common/http.hpp 750d3bfba1647624983108bdd23295a3b3091fe4 > src/common/http.cpp 8d3a4ad63bd74e0313082bad3d89c21fbf54f256 > > > Diff: https://reviews.apache.org/r/65311/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
