> On March 7, 2018, 7:21 p.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 4136 (original), 4184 (patched) > > <https://reviews.apache.org/r/63992/diff/3/?file=1969375#file1969375line4188> > > > > If the operation has an operation ID, we'll always land on this > > `continue` even if the validations/checks pass. > > > > This means that line #4187 will be skipped, and operations with an > > operatin ID won't be added to the object passed to the `_accept` > > continuation. > > Greg Mann wrote: > Ah thank you; this should be removed.
I elected to add another case to the conditional because I thought this was more readable; let me know what you think. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review198812 ----------------------------------------------------------- On March 13, 2018, 4:38 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63992/ > ----------------------------------------------------------- > > (Updated March 13, 2018, 4:38 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. > > > Bugs: MESOS-8190 > https://issues.apache.org/jira/browse/MESOS-8190 > > > Repository: mesos > > > Description > ------- > > This patch adds code to send operation status updates in the master's > ACCEPT call handler. In cases where operations are dropped and in > cases where offer operation IDs are set when they should not be, the > master will send operation status updates for the dropped operations. > > > Diffs > ----- > > src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f > > > Diff: https://reviews.apache.org/r/63992/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
