> On March 14, 2018, 3:55 p.m., Benjamin Bannier wrote: > > I am confused why this patch does not add a status update manager for > > master-generated operation status updates. Right now there is no way for > > frameworks to e.g., reconcile failed operations after framework failover > > since the master does not remember any operation status updates in > > generated (in addition to not retrying their delivery). > > > > Apart from that the changes seem to do what they advertise, but I wonder > > whether now would be the right time to address the numerous `TOOD`s, e.g., > > the one about adding a helper to encapsulate the code around `drop`ped > > operations. I am pretty sure this will be useful in the future.
We're following the pattern we have already for task status updates, and not requiring acknowledgement for master-generated operation status updates. If the framework attempts to reconcile such an operation, it will indeed be unknown. I think that adding a status update manager to the master for this purpose alone introduces more complexity than it's worth. It seems to have worked fine thus far for tasks? I think that adding the `drop` overload could be done in a separate patch. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199172 ----------------------------------------------------------- On March 13, 2018, 9:49 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63992/ > ----------------------------------------------------------- > > (Updated March 13, 2018, 9:49 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. > > > Bugs: MESOS-8190 > https://issues.apache.org/jira/browse/MESOS-8190 > > > Repository: mesos > > > Description > ------- > > This patch adds code to send operation status updates in the master's > ACCEPT call handler. In cases where operations are dropped and in > cases where offer operation IDs are set when they should not be, the > master will send operation status updates for the dropped operations. > > > Diffs > ----- > > src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f > > > Diff: https://reviews.apache.org/r/63992/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
