----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199121 -----------------------------------------------------------
src/master/master.cpp Lines 4075-4082 (original), 4111-4117 (patched) <https://reviews.apache.org/r/63992/#comment279431> Nitpick: the comment looks a bit redundant. I'd go with this: ``` // The `id` field is set, which means operation feedback is requested. // // Operation feedback is not supported for LAUNCH or LAUNCH_GROUP // operations, so we drop them and send TASK_ERROR status updates. // // For other operatations verify that they are destined for an agent // with the RESOURCE_PROVIDER capability. ``` - Gaston Kleiman On March 13, 2018, 9:38 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63992/ > ----------------------------------------------------------- > > (Updated March 13, 2018, 9:38 a.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. > > > Bugs: MESOS-8190 > https://issues.apache.org/jira/browse/MESOS-8190 > > > Repository: mesos > > > Description > ------- > > This patch adds code to send operation status updates in the master's > ACCEPT call handler. In cases where operations are dropped and in > cases where offer operation IDs are set when they should not be, the > master will send operation status updates for the dropped operations. > > > Diffs > ----- > > src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f > > > Diff: https://reviews.apache.org/r/63992/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
