> On March 19, 2018, 9:50 a.m., Zhitao Li wrote: > > src/master/master.cpp > > Lines 5934 (patched) > > <https://reviews.apache.org/r/64618/diff/8/?file=1975984#file1975984line5935> > > > > whitespace line after multi-line log > > Gaston Kleiman wrote: > Do we have an official rule saying that there should be an empty line > after a multi-line log message? > > I'm asking because I just looked at `master.cpp` and the style is not > consistent. > > Here are multiple examples without an empty line: > > > https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L5763-L5792 > > https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L570-L572 > > https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L599-L602 > > https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L1487-L1489 > > https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L3167-L3186 > > https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L3321-L3333 > > There are also multiple places where a mult-line log message is indeed > followed by an empty line. If we want to enforce a rule, then we should > probably do a sweep. > > Zhitao Li wrote: > http://mesos.apache.org/documentation/latest/c++-style-guide/#empty-lines > did not list log lines as exception, so we should either relax on the style > guide or still stick to it, I guess? > > Totally agreed that we should have a sweep on this.
Did a sweep here: https://reviews.apache.org/r/66142/ - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review199426 ----------------------------------------------------------- On March 16, 2018, 12:57 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64618/ > ----------------------------------------------------------- > > (Updated March 16, 2018, 12:57 p.m.) > > > Review request for mesos, Greg Mann and Zhitao Li. > > > Bugs: MESOS-8184 > https://issues.apache.org/jira/browse/MESOS-8184 > > > Repository: mesos > > > Description > ------- > > Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. > > > Diffs > ----- > > src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f > src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 > src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f > > > Diff: https://reviews.apache.org/r/64618/diff/8/ > > > Testing > ------- > > `make check` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
