----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65962/#review199541 -----------------------------------------------------------
src/launcher/default_executor.cpp Lines 943-958 (original) <https://reviews.apache.org/r/65962/#comment279828> I'd rather see such code shuffling in a separate patch. It is not strictly equivalent (for example, before if the container is the last one, shutdown is initiated immediately, while now if-blob will be executed first. - Alexander Rukletsov On March 19, 2018, 4:36 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65962/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 4:36 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > `Owned` pointers are copied in multiple places of the default executor. > This violates the semantic of owned pointers and works only because > `Owned` is currently implemented with `shared_ptr`, it would otherwise > lead to double-freeing the pointers. > > This patch changes those places to use references to the original > `Owned` objects or raw pointers instead of copies. > > > Diffs > ----- > > src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 > > > Diff: https://reviews.apache.org/r/65962/diff/3/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*Default*"` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
