> On March 22, 2018, 6:13 a.m., Alexander Rukletsov wrote: > > src/launcher/default_executor.cpp > > Line 979 (original), 961 (patched) > > <https://reviews.apache.org/r/65962/diff/3/?file=1978911#file1978911line980> > > > > Not yours, but maybe you can fix this `taskId` variable shadowing in a > > subsequent patch?
Sure, here you go: https://reviews.apache.org/r/66234/ - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65962/#review199676 ----------------------------------------------------------- On March 21, 2018, 2:13 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65962/ > ----------------------------------------------------------- > > (Updated March 21, 2018, 2:13 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Joseph > Wu. > > > Bugs: MESOS-8530 > https://issues.apache.org/jira/browse/MESOS-8530 > > > Repository: mesos > > > Description > ------- > > `Owned` pointers are copied in multiple places of the default executor. > This violates the semantic of owned pointers and works only because > `Owned` is currently implemented with `shared_ptr`, it would otherwise > lead to double-freeing the pointers. > > This patch changes those places to use references to the original > `Owned` objects or raw pointers instead of copies. > > > Diffs > ----- > > src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 > > > Diff: https://reviews.apache.org/r/65962/diff/5/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
