> On March 23, 2018, 6 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2406-2407 (patched) > > <https://reviews.apache.org/r/66143/diff/4/?file=1985519#file1985519line2406> > > > > Let's use this opportunity to improve this error message. The precise > > reason for denied authorization is actually dependent on the authorizer - > > we give the entire framework info and task info to the authorizer, and it > > decides precisely what to use for authorization. > > > > Maybe something like: > > > > "Framework " + stringify(frameworkId) + " is not authorized to launch > > task " + stringify(task_)
This would also mean you could remove the other code above related to the 'user'. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/#review199854 ----------------------------------------------------------- On March 22, 2018, 5:26 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66143/ > ----------------------------------------------------------- > > (Updated March 22, 2018, 5:26 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > This helps to encapsulate a task launch into a single > future which will come in handy when enforcing the task > launch order. > > Affected tests are also updated. > > > Diffs > ----- > > src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb > src/slave/slave.cpp 915d4f1bbd642ca5d2587cfdd846262cb7e08788 > src/tests/mock_slave.hpp 8ec2b65a75f774d970ef6507df8b0c02fda5f2fd > src/tests/mock_slave.cpp 8ec55b6aa84dd8b1c3743cbcdc246311585d0f63 > src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354 > > > Diff: https://reviews.apache.org/r/66143/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
