> On April 2, 2018, 4:21 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2396-2398 (patched) > > <https://reviews.apache.org/r/66143/diff/6/?file=1991118#file1991118line2398> > > > > Looks like we don't need this local variable?
You mean passing the whole error message directly to the function? I feel that hurts readability. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/#review200325 ----------------------------------------------------------- On April 3, 2018, 10:38 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66143/ > ----------------------------------------------------------- > > (Updated April 3, 2018, 10:38 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > This helps to encapsulate a task launch into a single > future which will come in handy when enforcing the task > launch order. > > Affected tests are also updated. > > > Diffs > ----- > > src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb > src/slave/slave.cpp a4bd4ccd3fc59c3c0e462d9b480f5424b3e52d7a > src/tests/mock_slave.hpp 8ec2b65a75f774d970ef6507df8b0c02fda5f2fd > src/tests/mock_slave.cpp 8ec55b6aa84dd8b1c3743cbcdc246311585d0f63 > src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 > > > Diff: https://reviews.apache.org/r/66143/diff/8/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
