----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/#review200325 -----------------------------------------------------------
src/slave/slave.cpp Line 2332 (original), 2345 (patched) <https://reviews.apache.org/r/66143/#comment281022> As in the previous review, ditto here regarding the naming of `framework_`. Let's switch to `_framework` for local consistency. src/slave/slave.cpp Lines 2354-2356 (patched) <https://reviews.apache.org/r/66143/#comment281024> How about "Authorization failed for <task> of framework <frameworkID>: <error>" src/slave/slave.cpp Lines 2358 (patched) <https://reviews.apache.org/r/66143/#comment281023> Ditto regarding the naming of `task_` here. src/slave/slave.cpp Lines 2384 (patched) <https://reviews.apache.org/r/66143/#comment281025> Ditto regarding naming of `framework_`, here as well as `task_` and `framework_` below. src/slave/slave.cpp Lines 2386-2389 (patched) <https://reviews.apache.org/r/66143/#comment281028> How about "Cannot handle authorization failure for <task> because the framework <frameworkID> does not exist" src/slave/slave.cpp Lines 2396-2398 (patched) <https://reviews.apache.org/r/66143/#comment281029> Looks like we don't need this local variable? src/slave/slave.cpp Lines 2428-2430 (patched) <https://reviews.apache.org/r/66143/#comment281030> This can be a `const string`. Also, let's be consistent and use the same indentation here that you use for other error strings above. - Greg Mann On April 2, 2018, 5:59 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66143/ > ----------------------------------------------------------- > > (Updated April 2, 2018, 5:59 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > This helps to encapsulate a task launch into a single > future which will come in handy when enforcing the task > launch order. > > Affected tests are also updated. > > > Diffs > ----- > > src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb > src/slave/slave.cpp a4bd4ccd3fc59c3c0e462d9b480f5424b3e52d7a > src/tests/mock_slave.hpp 8ec2b65a75f774d970ef6507df8b0c02fda5f2fd > src/tests/mock_slave.cpp 8ec55b6aa84dd8b1c3743cbcdc246311585d0f63 > src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 > > > Diff: https://reviews.apache.org/r/66143/diff/6/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
