----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review200296 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/xfs/disk.cpp Line 304 (original), 317-318 (patched) <https://reviews.apache.org/r/66001/#comment280988> Keep `infos.contains(containerId)` check here. Otherwise you can just remove this method, it will be inherited from `MesosIsolatorProcess`. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Line 309 (original), 328 (patched) <https://reviews.apache.org/r/66001/#comment280987> Style: add a space after `if` and before `{`. Please read the [code style guide](http://mesos.apache.org/documentation/latest/c++-style-guide/) and look at the code around to see how to format it. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 392 (patched) <https://reviews.apache.org/r/66001/#comment280992> Ditto re spaces around the bracketed condition. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 393 (patched) <https://reviews.apache.org/r/66001/#comment281007> This should be configurable. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 396 (patched) <https://reviews.apache.org/r/66001/#comment280991> Combine this with `status` declaration that is currently on line 386. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 420 (patched) <https://reviews.apache.org/r/66001/#comment280996> What about `QuotaPolicy::ENFORCING_PASSIVE`? The monitoring loop should not be started if we don't intend to kill containers. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 423-424 (patched) <https://reviews.apache.org/r/66001/#comment280994> Style: The continuation should be indented with 4 spaces. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 426-427 (patched) <https://reviews.apache.org/r/66001/#comment280995> Style: The second line is overindented by 1 space. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 441-443 (patched) <https://reviews.apache.org/r/66001/#comment281009> Continuation with function arguments should be indented with 4 spaces. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 411-442 (original), 498-530 (patched) <https://reviews.apache.org/r/66001/#comment280998> What's the point of this drive-by change? The only change here is `info.` removal, right? src/slave/containerizer/mesos/isolators/xfs/utils.hpp Line 100 (original) <https://reviews.apache.org/r/66001/#comment280999> Keep this newline. src/slave/containerizer/mesos/isolators/xfs/utils.hpp Line 105 (original), 108-110 (patched) <https://reviews.apache.org/r/66001/#comment281000> Add 1 more newline between the prototypes. - Ilya Pronin On March 23, 2018, 9:13 a.m., Harold Dost wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66001/ > ----------------------------------------------------------- > > (Updated March 23, 2018, 9:13 a.m.) > > > Review request for mesos and James Peach. > > > Bugs: MESOS-6575 > https://issues.apache.org/jira/browse/MESOS-6575 > > > Repository: mesos > > > Description > ------- > > New Flags for disk/xfs isolator: > - xfs_kill_containers - This will create a 10 MB buffer between the soft > and hard limits, and when the soft limit is exceeded it will > subsequently be killed. > > Functionality > - This by default disabled behavior allows for the `disk/xfs` isolator > to kill containers which surpass their limit. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 07e68a777aefba4dd35066f2eb207bba7f199d83 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 8d9f8f846866f9de377c59cb7fb311041283ba70 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > e034133629a9c1cf58b776f8da2a93421332cee0 > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > 2708524add1ff693b616d4fb241c4a0a3070520b > src/slave/flags.hpp 949a4783caf8aac9a246a98525a5287b0f8256d8 > src/slave/flags.cpp dd8dfb7a8a9f7c6030939c9eea841eb47deadfc4 > src/tests/containerizer/xfs_quota_tests.cpp > 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe > > > Diff: https://reviews.apache.org/r/66001/diff/11/ > > > Testing > ------- > > > Thanks, > > Harold Dost > >
