> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 304 (original), 317-318 (patched) > > <https://reviews.apache.org/r/66001/diff/11/?file=1986464#file1986464line319> > > > > Keep `infos.contains(containerId)` check here. Otherwise you can just > > remove this method, it will be inherited from `MesosIsolatorProcess`.
I believe I addressed this in relation to one of jpeach's comments. > On April 2, 2018, 8:30 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 393 (patched) > > <https://reviews.apache.org/r/66001/diff/11/?file=1986464#file1986464line396> > > > > This should be configurable. So I had this configurable previously if you look at previous diff revisions. I was asked to remove it. > On April 2, 2018, 8:30 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 411-442 (original), 498-530 (patched) > > <https://reviews.apache.org/r/66001/diff/11/?file=1986464#file1986464line502> > > > > What's the point of this drive-by change? The only change here is > > `info.` removal, right? This is because I had to add a promise to the info for the functionality of the limitation, and the nature of promises is that they cannot be copied. As a result I had to grab the specific information needed for this part of the code. - Harold ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review200296 ----------------------------------------------------------- On March 23, 2018, 4:13 p.m., Harold Dost wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66001/ > ----------------------------------------------------------- > > (Updated March 23, 2018, 4:13 p.m.) > > > Review request for mesos and James Peach. > > > Bugs: MESOS-6575 > https://issues.apache.org/jira/browse/MESOS-6575 > > > Repository: mesos > > > Description > ------- > > New Flags for disk/xfs isolator: > - xfs_kill_containers - This will create a 10 MB buffer between the soft > and hard limits, and when the soft limit is exceeded it will > subsequently be killed. > > Functionality > - This by default disabled behavior allows for the `disk/xfs` isolator > to kill containers which surpass their limit. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 07e68a777aefba4dd35066f2eb207bba7f199d83 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 8d9f8f846866f9de377c59cb7fb311041283ba70 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > e034133629a9c1cf58b776f8da2a93421332cee0 > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > 2708524add1ff693b616d4fb241c4a0a3070520b > src/slave/flags.hpp 949a4783caf8aac9a246a98525a5287b0f8256d8 > src/slave/flags.cpp dd8dfb7a8a9f7c6030939c9eea841eb47deadfc4 > src/tests/containerizer/xfs_quota_tests.cpp > 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe > > > Diff: https://reviews.apache.org/r/66001/diff/11/ > > > Testing > ------- > > > Thanks, > > Harold Dost > >
