----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/#review200979 -----------------------------------------------------------
Haven't managed to make a full review of the chain, yet, one small technicality noted below. src/resource_provider/storage/provider.cpp Lines 3061 (patched) <https://reviews.apache.org/r/65665/#comment281899> Since this is an internal message, we should be able to enumerate the full set of possible values. With that we should remove this `default` case, turning the runtime into a compile time error. - Benjamin Bannier On April 12, 2018, 7:15 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65665/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 7:15 a.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan > Schlicht. > > > Bugs: MESOS-8383 > https://issues.apache.org/jira/browse/MESOS-8383 > > > Repository: mesos > > > Description > ------- > > This patch adds `operations_pending`, `operations_finished`, > `operations_failed`, `operations_error` (currently unused), and > `operations_dropped` metrics to count the occurances of these operation > states. > > Additionally, An error log in `_applyOperation()` is removed because the > error is already logged at the call site. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > a07620d1c4bf618f669575b3e183bf598da905a6 > > > Diff: https://reviews.apache.org/r/65665/diff/4/ > > > Testing > ------- > > sudo make check > A unit test is added in the next patch in chain. > > > Thanks, > > Chun-Hung Hsiao > >
