> On April 20, 2018, 12:57 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Line 1010 (original), 1011 (patched) > > <https://reviews.apache.org/r/65594/diff/8/?file=1996911#file1996911line1015> > > > > Nit: _pending operations_ should be specific enough as this list is > > neither exhaustive today nor will remain in the future.
I'm specifically talking about `CREATE_VOLUME` and `CREATE_BLOCK` here. `DESTROY_VOLUME` and `DESTROY_BLOCK` don't need the profile info. > On April 20, 2018, 12:57 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Line 1021 (original), 1014 (patched) > > <https://reviews.apache.org/r/65594/diff/8/?file=1996911#file1996911line1026> > > > > Both `disk` and `profile` are `optional` fields. We should check > > explicitly whether they are set (otherwise we might at some point e.g., hit > > a failure where the profile `` (empty string) was not found. The implicit invariant here is that each resource either has it's id or profile set. I'll add a check to make it more explicit. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review201627 ----------------------------------------------------------- On April 12, 2018, 3:35 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65594/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 3:35 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-8492 > https://issues.apache.org/jira/browse/MESOS-8492 > > > Repository: mesos > > > Description > ------- > > SLRP now checkpoints profiles associated with storage pools, and does > not depend on the `DiskProfileAdaptor` module to return the set of > previously-known profiles during recovery. > > > Diffs > ----- > > src/resource_provider/state.proto 8577b58b8cdb63b3daddf06ea5d12f80f9d42f2b > src/resource_provider/storage/provider.cpp > a07620d1c4bf618f669575b3e183bf598da905a6 > > > Diff: https://reviews.apache.org/r/65594/diff/8/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
