> On April 20, 2018, 12:57 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 3276 (patched) > > <https://reviews.apache.org/r/65594/diff/8/?file=1996911#file1996911line3318> > > > > Should we capture this? > > > > ProfileInfo& profile_ = *(storage->mutable_profiles())[profile]; > > > > No strong opinion, it seems hard to make interacting with proto maps > > nice. > > Chun-Hung Hsiao wrote: > I'll do `ProfileInfo& profileInfo_ = ...`.
BTW the deference operator (`*`) applies on `mutable_profiles()` not `[]`. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review201627 ----------------------------------------------------------- On April 12, 2018, 3:35 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65594/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 3:35 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-8492 > https://issues.apache.org/jira/browse/MESOS-8492 > > > Repository: mesos > > > Description > ------- > > SLRP now checkpoints profiles associated with storage pools, and does > not depend on the `DiskProfileAdaptor` module to return the set of > previously-known profiles during recovery. > > > Diffs > ----- > > src/resource_provider/state.proto 8577b58b8cdb63b3daddf06ea5d12f80f9d42f2b > src/resource_provider/storage/provider.cpp > a07620d1c4bf618f669575b3e183bf598da905a6 > > > Diff: https://reviews.apache.org/r/65594/diff/8/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
