----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review202180 -----------------------------------------------------------
src/tests/persistent_volume_tests.cpp Lines 788 (patched) <https://reviews.apache.org/r/66220/#comment283870> If you decide to merge two `acceptOffers` calls, I suggest s/`offerBeforeCreate`/`offersBeforeOperations`/. Otherwise, the name is appropriate. src/tests/persistent_volume_tests.cpp Lines 898 (patched) <https://reviews.apache.org/r/66220/#comment283868> Suggestion: How about `NonSpeculativeShrinkAndLaunch`? src/tests/persistent_volume_tests.cpp Lines 930 (patched) <https://reviews.apache.org/r/66220/#comment283869> If you decide to merge two `acceptOffers` calls, the name is appropriate. Otherwise I suggest s/`offersBeforeOperations`/`offersBeforeCreate`/ for consistency. - Chun-Hung Hsiao On April 27, 2018, 8:04 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66220/ > ----------------------------------------------------------- > > (Updated April 27, 2018, 8:04 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66220/diff/8/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
