> On April 25, 2018, 9:09 a.m., Greg Mann wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 451 (patched) > > <https://reviews.apache.org/r/66220/diff/6/?file=2006752#file2006752line451> > > > > It's not 100% clear to me if these tests actually verify that the > > agent's resource checkpointing has occurred? IIUC, settling the clock after > > awaiting on the `ApplyOperationMessage` which applies the GROW or SHRINK > > may be sufficient to verify this?
They don't. I've rewrittent the comment. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201843 ----------------------------------------------------------- On April 27, 2018, 1:04 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66220/ > ----------------------------------------------------------- > > (Updated April 27, 2018, 1:04 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66220/diff/8/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
