----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201843 -----------------------------------------------------------
src/tests/persistent_volume_tests.cpp Lines 451 (patched) <https://reviews.apache.org/r/66220/#comment283453> It's not 100% clear to me if these tests actually verify that the agent's resource checkpointing has occurred? IIUC, settling the clock after awaiting on the `ApplyOperationMessage` which applies the GROW or SHRINK may be sufficient to verify this? src/tests/persistent_volume_tests.cpp Lines 530-531 (patched) <https://reviews.apache.org/r/66220/#comment283439> Indented too far. src/tests/persistent_volume_tests.cpp Lines 539 (patched) <https://reviews.apache.org/r/66220/#comment283440> This accept call doesn't launch a task. src/tests/persistent_volume_tests.cpp Lines 552 (patched) <https://reviews.apache.org/r/66220/#comment283441> You could do `offersBeforeGrow->at(0)`, which I prefer. WDYT? Here and below. src/tests/persistent_volume_tests.cpp Lines 560 (patched) <https://reviews.apache.org/r/66220/#comment283442> Indent four more spaces. src/tests/persistent_volume_tests.cpp Lines 562 (patched) <https://reviews.apache.org/r/66220/#comment283443> s/leaves/leave/ src/tests/persistent_volume_tests.cpp Lines 571 (patched) <https://reviews.apache.org/r/66220/#comment283444> Indented too far. src/tests/persistent_volume_tests.cpp Lines 575 (patched) <https://reviews.apache.org/r/66220/#comment283446> This offer won't contain the original volume, right? src/tests/persistent_volume_tests.cpp Lines 585-586 (patched) <https://reviews.apache.org/r/66220/#comment283449> IIUC, the `Clock::settle()` here is ensuring that this test actually verifies that the agent's resources have been checkpointed? If so, I would recommend: 1) Add a comment explaining the reason for the settle. 2) Place the settle after the await. I think the two orderings are equivalent, but I think it's more readable if the settle is after the await? src/tests/persistent_volume_tests.cpp Lines 744-747 (patched) <https://reviews.apache.org/r/66220/#comment283452> Do we need a settle after this to ensure that the agent has checkpointed its resources? - Greg Mann On April 19, 2018, 4:39 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66220/ > ----------------------------------------------------------- > > (Updated April 19, 2018, 4:39 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66220/diff/7/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
