> On May 14, 2018, 9:34 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/path.hpp
> > Lines 74 (patched)
> > <https://reviews.apache.org/r/65811/diff/4/?file=2018188#file2018188line74>
> >
> >     This should just be `is Abs = path::absolute(path)`. The function is 
> > already written, also only performs pure lexical processing, and is 
> > cross-platform.

Will address that in another update.


> On May 14, 2018, 9:34 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/path.hpp
> > Lines 77 (patched)
> > <https://reviews.apache.org/r/65811/diff/4/?file=2018188#file2018188line77>
> >
> >     ;)
> >     
> >     Given some unit to tests to prove it, I don't see a reason why this 
> > wouldn't handle Windows paths pretty much as-is. Maybe one extra step to 
> > convert `/` to `\` if the given separator is `\`. Since often "normalizing" 
> > on Windows also means converting slashes to something consistent (and we 
> > opt for `\` because of long paths).

Will do in a separate patch.


> On May 14, 2018, 9:34 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/path.hpp
> > Lines 103-104 (patched)
> > <https://reviews.apache.org/r/65811/diff/4/?file=2018188#file2018188line103>
> >
> >     I guess, to make it cross platform, you'd want to save the original 
> > prefix (which could be a tad annoying), and then re-add it here.

Indeed. As said in a previous comment, will do that in a separate patch for 
cross platform support.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review203072
-----------------------------------------------------------


On May 17, 2018, 1:06 a.m., Jason Lai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65811/
> -----------------------------------------------------------
> 
> (Updated May 17, 2018, 1:06 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, 
> James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
>     https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add `path::normalize` to stout for normalizing path (for POSIX only now).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/path.hpp 
> 27438d31617b3b78bf3d4deffd25c93340610e8d 
> 
> 
> Diff: https://reviews.apache.org/r/65811/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Reply via email to