----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review203605 -----------------------------------------------------------
Please update the commit message to < 72 characters: ``` $ ./support/apply-reviews.py -c -r 67177 2018-05-22 15:13:11 URL:https://reviews.apache.org/r/65811/diff/raw/ [2315/2315] -> "65811.patch" [1] Checking 1 C++ file Done processing 3rdparty/stout/include/stout/path.hpp Total errors found: 0 Total errors found: 0 No JavaScript files to lint No Python files to lint Error: No line in the commit message summary may exceed 72 characters. ``` I suggest that the commit message should be: ``` Added Stout `path::normalize` API for POSIX paths. Added `path::normalize` to normalize a given pathname and remove redundant separators and up-level references. This function follows the rules described in path_resolution(7) for Linux, however, it only performs pure lexical processing without touching the actual filesystem. ``` - James Peach On May 17, 2018, 1:06 a.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65811/ > ----------------------------------------------------------- > > (Updated May 17, 2018, 1:06 a.m.) > > > Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, > James Peach, and Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Add `path::normalize` to stout for normalizing path (for POSIX only now). > > > Diffs > ----- > > 3rdparty/stout/include/stout/path.hpp > 27438d31617b3b78bf3d4deffd25c93340610e8d > > > Diff: https://reviews.apache.org/r/65811/diff/5/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
