----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review203453 -----------------------------------------------------------
3rdparty/stout/include/stout/path.hpp Lines 60 (patched) <https://reviews.apache.org/r/65811/#comment285686> In fact, I'd return `Try` if it escapes the root path, this will allow us to avoid some silent errors in the subsequent patch (silently change the intended path, instead of a failure). - Jie Yu On May 17, 2018, 1:06 a.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65811/ > ----------------------------------------------------------- > > (Updated May 17, 2018, 1:06 a.m.) > > > Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, > James Peach, and Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Add `path::normalize` to stout for normalizing path (for POSIX only now). > > > Diffs > ----- > > 3rdparty/stout/include/stout/path.hpp > 27438d31617b3b78bf3d4deffd25c93340610e8d > > > Diff: https://reviews.apache.org/r/65811/diff/5/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
