----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review203404 -----------------------------------------------------------
Patch looks great! Reviews applied: [66882, 66819, 66820, 66822, 66823, 66845, 66825, 66846, 66847, 66841, 66842, 66843, 67147, 66844, 66855, 66861, 66856, 66870, 66874, 67043, 66883, 67187] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 17, 2018, 6:08 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67187/ > ----------------------------------------------------------- > > (Updated May 17, 2018, 6:08 p.m.) > > > Review request for mesos, Gaston Kleiman and Gilbert Song. > > > Bugs: MESOS-8847 > https://issues.apache.org/jira/browse/MESOS-8847 > > > Repository: mesos > > > Description > ------- > > This patch adds `MasterTest.TaskStateMetrics`, which verifies that > per-framework task state metrics for both terminal and active task > states report correct values, even after agent reregistration. > > > Diffs > ----- > > src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31 > > > Diff: https://reviews.apache.org/r/67187/diff/1/ > > > Testing > ------- > > The new test was run ~10,000 times with no failures. > > > Thanks, > > Greg Mann > >
