----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review206466 -----------------------------------------------------------
src/tests/master_tests.cpp Lines 9107 (patched) <https://reviews.apache.org/r/67187/#comment289434> Do we have to specify the resources? I think the defaults should be good. src/tests/master_tests.cpp Lines 9110-9111 (patched) <https://reviews.apache.org/r/67187/#comment289436> I'd add a comment here saying that we set the filter to 0s to get an offer without having to wait until the filter expires. src/tests/master_tests.cpp Lines 9113-9117 (patched) <https://reviews.apache.org/r/67187/#comment289435> Can we use the new helpers here? ``` testing::Sequence taskSequence1; Future<TaskStatus> running1; EXPECT_CALL( sched, statusUpdate(&driver, AllOf( TaskStatusTaskIdEq(task1.id()), TaskStatusStateEq(TASK_STARTING)))) .InSequence(taskSequence1) EXPECT_CALL( sched, statusUpdate(&driver, AllOf( TaskStatusTaskIdEq(task1.id()), TaskStatusStateEq(TASK_RUNNING)))) .InSequence(taskSequence1) .WillOnce(FutureArg<1>(&running1)); ``` src/tests/master_tests.cpp Lines 9147-9154 (patched) <https://reviews.apache.org/r/67187/#comment289437> Ditto using the "new" awsum helpers =). src/tests/master_tests.cpp Lines 9214-9216 (patched) <https://reviews.apache.org/r/67187/#comment289439> Note: this might not be enough to make the agent re-register. This made some of my tests that follow this pattern flaky. I don't know why this happens, but the test will probably become stable if you add `Clock::resume()` here. - Gastón Kleiman On July 17, 2018, 6:46 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67187/ > ----------------------------------------------------------- > > (Updated July 17, 2018, 6:46 p.m.) > > > Review request for mesos, Gastón Kleiman and Gilbert Song. > > > Bugs: MESOS-8847 > https://issues.apache.org/jira/browse/MESOS-8847 > > > Repository: mesos > > > Description > ------- > > This patch adds `MasterTest.TaskStateMetrics`, which verifies that > per-framework task state metrics for both terminal and active task > states report correct values, even after agent reregistration. > > > Diffs > ----- > > src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb > > > Diff: https://reviews.apache.org/r/67187/diff/4/ > > > Testing > ------- > > The new test was run ~10,000 times with no failures. > > > Thanks, > > Greg Mann > >
