----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203706 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/io/switchboard.cpp Lines 322 (patched) <https://reviews.apache.org/r/67241/#comment285991> I'd avoid question mark in the log. Please use statement: "IOSwitchboard server is (not) required" - Jie Yu On May 23, 2018, 1:57 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67241/ > ----------------------------------------------------------- > > (Updated May 23, 2018, 1:57 a.m.) > > > Review request for mesos, Gaston Kleiman, Jie Yu, Qian Zhang, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added isolator logs for volume/secret isolator and container logger. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > 517d45903bc5095f2f954b95feb61c8717d395f0 > src/slave/containerizer/mesos/isolators/volume/secret.cpp > 8071e4ee808bc825b13a6291767778d6ce3c2746 > > > Diff: https://reviews.apache.org/r/67241/diff/2/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
