> On May 21, 2018, 5:08 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 310-311 (patched) > > <https://reviews.apache.org/r/67241/diff/1/?file=2026801#file2026801line310> > > > > I'd print out some infomation that's relevant to this isolator for us > > to determine the following condition `requiresServer`. For example, if the > > container has tty specified.
I updated the patch with showing "requiredServer as Yes/No". Since operators may not understand the logic between `(has_tty and DEBUG_container)` and `requiresServer`. Maybe we should just indicate whether the IOSwitchboard server is needed? - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203544 ----------------------------------------------------------- On May 22, 2018, 6:57 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67241/ > ----------------------------------------------------------- > > (Updated May 22, 2018, 6:57 p.m.) > > > Review request for mesos, Gaston Kleiman, Jie Yu, Qian Zhang, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added isolator logs for volume/secret isolator and container logger. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > 517d45903bc5095f2f954b95feb61c8717d395f0 > src/slave/containerizer/mesos/isolators/volume/secret.cpp > 8071e4ee808bc825b13a6291767778d6ce3c2746 > > > Diff: https://reviews.apache.org/r/67241/diff/2/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
