-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
(Updated May 24, 2018, 3:28 a.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Switch-case on a non-constant to make the sanity check effective.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/discarded`
To add these per-CSI-call metrics, we introduced class template
`messo::csi::v0::Client::MethodName` to translate RPC methods of the CSI
client into string names, and added the `call` helper function in SLRP
to intercept CSI calls and update the corresponding metrics.
Diffs (updated)
-----
src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809
src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9
src/resource_provider/storage/provider.cpp
63b5d7e5f10d6ad02b5cd11b119def3b4abf4180
Diff: https://reviews.apache.org/r/67255/diff/5/
Changes: https://reviews.apache.org/r/67255/diff/4-5/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao
