----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67255/#review204137 -----------------------------------------------------------
Fix it, then Ship it! src/csi/client.hpp Lines 68 (patched) <https://reviews.apache.org/r/67255/#comment286533> nits: I'd just make this consistent with others :) ``` template <> process::Future<DeleteVolumeResponse> Client::call<DELETE_VOLUME>( const DeleteVolumeRequest& request); ``` Ditto below. src/resource_provider/storage/provider.cpp Lines 1776 (patched) <https://reviews.apache.org/r/67255/#comment286534> Does this work? Can you make it more verbose if that's your intention to log here. - Jie Yu On May 30, 2018, 3:01 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67255/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 3:01 a.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan > Schlicht. > > > Bugs: MESOS-8943 > https://issues.apache.org/jira/browse/MESOS-8943 > > > Repository: mesos > > > Description > ------- > > For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following > metrics for SLRP: > `csi_plugin/rpcs/csi.v0.Identity.Probe/pending` > `csi_plugin/rpcs/csi.v0.Identity.Probe/successes` > `csi_plugin/rpcs/csi.v0.Identity.Probe/errors` > `csi_plugin/rpcs/csi.v0.Identity.Probe/cancelled` > > To add these per-CSI-call metrics, each method in `csi::v0::Client`, > e.g., `csi::v0::Client::Probe`, is changed to > `csi::v0::Client::call<PROBE>`, to make RPC calls based on the RPC enum > value. A `call` helper function in SLRP is also added to intercept CSI > calls and update the corresponding metrics. > > > Diffs > ----- > > src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809 > src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9 > src/resource_provider/storage/provider.cpp > 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 > src/tests/csi_client_tests.cpp d5993d617056e86ae5a1224258cc6e0741466166 > > > Diff: https://reviews.apache.org/r/67255/diff/8/ > > > Testing > ------- > > sudo make check > > A unit test for the metrics will be introduced in the next patch. > > > Thanks, > > Chun-Hung Hsiao > >
