-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
(Updated May 31, 2018, 11:06 p.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Jie's comments.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/cancelled`
To add these per-CSI-call metrics, each method in `csi::v0::Client`,
e.g., `csi::v0::Client::Probe`, is changed to
`csi::v0::Client::call<PROBE>`, to make RPC calls based on the RPC enum
value. A `call` helper function in SLRP is also added to intercept CSI
calls and update the corresponding metrics.
Diffs (updated)
-----
src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809
src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9
src/resource_provider/storage/provider.cpp
2c7dd8d96915d68a7cdfcb870d5448bc25ea9011
src/tests/csi_client_tests.cpp d5993d617056e86ae5a1224258cc6e0741466166
Diff: https://reviews.apache.org/r/67255/diff/9/
Changes: https://reviews.apache.org/r/67255/diff/8-9/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao
