----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67286/#review204521 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/internal/windows/inherit.hpp Lines 55 (patched) <https://reviews.apache.org/r/67286/#comment287064> Note that this destructor is called regardless of the state of `attribute_list`. So, it will call `::DeleteProcThreadAttributeList()` for these two cases, where `::InitializeProcThreadAttributeList` hasn't succeeded yet. ``` if (attribute_list == nullptr) { return WindowsError(ERROR_OUTOFMEMORY); // Destructor calls `::DeleteProc...(nullptr)` } result = ::InitializeProcThreadAttributeList(attribute_list.get(), 1, 0, &size); if (result == FALSE) { return WindowsError(); // Destructor calls `::DeleteProc...()` on uninitialized attribute_list. } ``` 3rdparty/stout/include/stout/os/windows/shell.hpp Lines 245 (patched) <https://reviews.apache.org/r/67286/#comment287065> I think the mesos empty vector style is `const std::vector<int_fd>& whitelist_fds = {}` . - Akash Gupta On May 24, 2018, 10:47 p.m., Radhika Jandhyala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67286/ > ----------------------------------------------------------- > > (Updated May 24, 2018, 10:47 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie > Yu, Li Li, and Radhika Jandhyala. > > > Bugs: MESOS-8926 > https://issues.apache.org/jira/browse/MESOS-8926 > > > Repository: mesos > > > Description > ------- > > White list fds that child processes can inherit in stout. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > 7dbde820e775cbaeb8db4bc4559ab432903e75ea > 3rdparty/stout/include/stout/os/windows/shell.hpp > 8da612af2888ff4d4d458ea5b16cdb08779b6f4c > > > Diff: https://reviews.apache.org/r/67286/diff/2/ > > > Testing > ------- > > All Mesos-tests > > > Thanks, > > Radhika Jandhyala > >
