----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67286/#review204548 -----------------------------------------------------------
Ship it! 3rdparty/stout/include/stout/internal/windows/inherit.hpp Lines 55 (patched) <https://reviews.apache.org/r/67286/#comment287106> `DeleteProcThreadAttributeList` doesn't seem to care if it fails, as it returns nothing, so to make the logic easier, we just bundled it into the destructor. - Andrew Schwartzmeyer On May 24, 2018, 3:47 p.m., Radhika Jandhyala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67286/ > ----------------------------------------------------------- > > (Updated May 24, 2018, 3:47 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie > Yu, Li Li, and Radhika Jandhyala. > > > Bugs: MESOS-8926 > https://issues.apache.org/jira/browse/MESOS-8926 > > > Repository: mesos > > > Description > ------- > > White list fds that child processes can inherit in stout. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > 7dbde820e775cbaeb8db4bc4559ab432903e75ea > 3rdparty/stout/include/stout/os/windows/shell.hpp > 8da612af2888ff4d4d458ea5b16cdb08779b6f4c > > > Diff: https://reviews.apache.org/r/67286/diff/2/ > > > Testing > ------- > > All Mesos-tests > > > Thanks, > > Radhika Jandhyala > >
