> On May 24, 2018, 6:42 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > > Lines 23 (patched) > > <https://reviews.apache.org/r/67286/diff/1/?file=2028379#file2028379line23> > > > > Do you know if this header might include `windows.h`? If it does, we > > should move this `#include` to `stout/windows.hpp` and then include that > > here to preserve Windows header ordering.
It does not include windows.h - Radhika ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67286/#review203795 ----------------------------------------------------------- On May 24, 2018, 10:47 p.m., Radhika Jandhyala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67286/ > ----------------------------------------------------------- > > (Updated May 24, 2018, 10:47 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie > Yu, Li Li, and Radhika Jandhyala. > > > Bugs: MESOS-8926 > https://issues.apache.org/jira/browse/MESOS-8926 > > > Repository: mesos > > > Description > ------- > > White list fds that child processes can inherit in stout. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > 7dbde820e775cbaeb8db4bc4559ab432903e75ea > 3rdparty/stout/include/stout/os/windows/shell.hpp > 8da612af2888ff4d4d458ea5b16cdb08779b6f4c > > > Diff: https://reviews.apache.org/r/67286/diff/2/ > > > Testing > ------- > > All Mesos-tests > > > Thanks, > > Radhika Jandhyala > >
