----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/#review205144 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/provisioner/docker/store.cpp Lines 40 (patched) <https://reviews.apache.org/r/66875/#comment288106> Why do we need this header file? src/slave/containerizer/mesos/provisioner/docker/store.cpp Lines 104-106 (patched) <https://reviews.apache.org/r/66875/#comment288105> A space missed between `)` and `:`. And can we merge these 3 line codes into 2 lines? ``` Metrics() : image_pull( "containerizer/mesos/provisioner/docker_store/image_pull", Hours(1)) ``` src/slave/containerizer/mesos/provisioner/docker/store.cpp Lines 111 (patched) <https://reviews.apache.org/r/66875/#comment288104> Kill this blank line. - Qian Zhang On June 21, 2018, 2:26 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66875/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 2:26 a.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-6451 > https://issues.apache.org/jira/browse/MESOS-6451 > > > Repository: mesos > > > Description > ------- > > This patch added pull latency tracking for docker store, which can tell > us both latency distribution of pull as well as number of pulls. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 6e7dc44321bff3198e5ffe69be1ba329be3ee31e > > > Diff: https://reviews.apache.org/r/66875/diff/3/ > > > Testing > ------- > > Ran agent in command line and trigger several launches through > `mesos-execute`, observed following metrics from agent endpoint: > > ``` > "containerizer/mesos/provisioner/docker_store/image_pull_ms": 3619.53408, > "containerizer/mesos/provisioner/docker_store/image_pull_ms/count": 2, > "containerizer/mesos/provisioner/docker_store/image_pull_ms/max": > 4208.662016, > "containerizer/mesos/provisioner/docker_store/image_pull_ms/min": > 3619.53408, > "containerizer/mesos/provisioner/docker_store/image_pull_ms/p50": > 3914.098048, > "containerizer/mesos/provisioner/docker_store/image_pull_ms/p90": > 4149.7492224, > "containerizer/mesos/provisioner/docker_store/image_pull_ms/p95": > 4179.2056192, > "containerizer/mesos/provisioner/docker_store/image_pull_ms/p99": > 4202.77073664, > "containerizer/mesos/provisioner/docker_store/image_pull_ms/p999": > 4208.072888064, > "containerizer/mesos/provisioner/docker_store/image_pull_ms/p9999": > 4208.6031032064, > ``` > > > Thanks, > > Zhitao Li > >
