----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/#review202200 -----------------------------------------------------------
Patch looks great! Reviews applied: [53105, 66875] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 30, 2018, 4:32 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66875/ > ----------------------------------------------------------- > > (Updated April 30, 2018, 4:32 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6451 > https://issues.apache.org/jira/browse/MESOS-6451 > > > Repository: mesos > > > Description > ------- > > This patch added pull latency tracking for docker store, which can tell > us both latency distribution of pull as well as number of pulls. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 8b3f07f5027cb90d4b4ed401960494709d3eda5f > > > Diff: https://reviews.apache.org/r/66875/diff/2/ > > > Testing > ------- > > Ran agent in command line and trigger several launches through > `mesos-execute`, observed following metrics from agent endpoint: > > ``` > "containerizer/mesos/docker_store/pull_ms": 4084.254208, > "containerizer/mesos/docker_store/pull_ms/count": 2, > "containerizer/mesos/docker_store/pull_ms/max": 4084.254208, > "containerizer/mesos/docker_store/pull_ms/min": 3525.044736, > "containerizer/mesos/docker_store/pull_ms/p50": 3804.649472, > "containerizer/mesos/docker_store/pull_ms/p90": 4028.3332608, > "containerizer/mesos/docker_store/pull_ms/p95": 4056.2937344, > "containerizer/mesos/docker_store/pull_ms/p99": 4078.66211328, > "containerizer/mesos/docker_store/pull_ms/p999": 4083.694998528, > "containerizer/mesos/docker_store/pull_ms/p9999": 4084.1982870528, > ``` > > > Thanks, > > Zhitao Li > >
