----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66820/#review205818 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.hpp Lines 2879 (patched) <https://reviews.apache.org/r/66820/#comment288725> Nit: I'd make this method take a const ref for consistency. But given that `State` is an enum, I don't think that making a copy has any performance impact. - Gastón Kleiman On June 27, 2018, 12:35 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66820/ > ----------------------------------------------------------- > > (Updated June 27, 2018, 12:35 a.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, > and Vinod Kone. > > > Bugs: MESOS-8919 > https://issues.apache.org/jira/browse/MESOS-8919 > > > Repository: mesos > > > Description > ------- > > Added per framework metrics 'subscribed' and helpers. > > > Diffs > ----- > > src/master/master.hpp 4180341e2c7b16503a4376c501f611bb78ba901c > src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a > src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b > src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 > > > Diff: https://reviews.apache.org/r/66820/diff/7/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
