> On July 6, 2018, 6:58 p.m., Gastón Kleiman wrote: > > src/master/master.hpp > > Lines 2879 (patched) > > <https://reviews.apache.org/r/66820/diff/7/?file=2046268#file2046268line2879> > > > > Nit: I'd make this method take a const ref for consistency. But given > > that `State` is an enum, I don't think that making a copy has any > > performance impact.
Fixed while committing. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66820/#review205818 ----------------------------------------------------------- On July 18, 2018, 1:33 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66820/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 1:33 a.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, > and Vinod Kone. > > > Bugs: MESOS-8919 > https://issues.apache.org/jira/browse/MESOS-8919 > > > Repository: mesos > > > Description > ------- > > Added per-framework 'subscribed' metric and helpers. > > > Diffs > ----- > > src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 > src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5 > src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b > src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 > > > Diff: https://reviews.apache.org/r/66820/diff/8/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
