----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review207822 -----------------------------------------------------------
Only half way through this patch. Will continue tomorrow. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Line 202 (original), 207 (patched) <https://reviews.apache.org/r/68401/#comment291379> I'm fine with this change. Just didn't see much value of printing this additional piece of information. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 240 (patched) <https://reviews.apache.org/r/68401/#comment291352> `fs::list` might be a better choice. Or, use `paths::getPersistentVolumnPaths` as suggested in my comments for a previous patch. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 438 (patched) <https://reviews.apache.org/r/68401/#comment291348> ``` error: control reaches end of non-void function [-Werror=return-type] ``` Let's include `stout/unreachable.hpp` and then add `UNREACHABLE()` at the end of this function. - Chun-Hung Hsiao On Aug. 16, 2018, 11:52 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68401/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2018, 11:52 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, > and Jiang Yan Xu. > > > Bugs: MESOS-5158 > https://issues.apache.org/jira/browse/MESOS-5158 > > > Repository: mesos > > > Description > ------- > > Added persistent volume support to the `disk/xfs` isolator. This > implementation largely tracks the `disk/du` implementation in that > we now keep a map of paths in each container info structure. We now > defer quota clean up to project ID reclaimation time so that we can > use the same mechanism for sandbox and persistent volume paths. > > We explicitly exclude mount disks from XFS project quotas, but we still > track them so that we can correctly publish their usage information in > the container `DiskStatistics` message. This means that mount disks are > not required to be XFS filesystems or have project quotas configured. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 38c467b47cb7c04803b0709b8239458fb26abb61 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 783da0407528c044035d18cc59a744353921d64c > src/tests/containerizer/xfs_quota_tests.cpp > 59ec182c1c3af3978156044f03d9e3d784d51fce > > > Diff: https://reviews.apache.org/r/68401/diff/1/ > > > Testing > ------- > > sudo make check (Fedora 28) > > > Thanks, > > James Peach > >
