> On Aug. 24, 2018, 11:38 p.m., Chun-Hung Hsiao wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > > Lines 94 (patched) > > <https://reviews.apache.org/r/68401/diff/1/?file=2074209#file2074209line94> > > > > I was wondering if a `hashmap<std::string, PathInfo>` or a > > `vector<PathInfo>` (with a path field in `PathInfo`. is better here. The > > only cane we use the key to find the `PathInfo` is for sandbox, but I feel > > that we could probably treat all paths homogeneously, > > so instead of the following in all methods: > > > > 1. Process the sandbox > > 2. Process the volume for each volume in paths > > > > We could just do: > > > > 1. Process the volume for each volume in paths (including the sandbox, > > whose `disk` is none) > > > > Also maybe `QuotaInfo` is a better name? > > > > Thoughts? > > James Peach wrote: > I ended up doing roughly what `posix/disk.cpp` does. I think that your > suggestion works well for `usage` but will be awkward in `update`. I'll see > whether I can find a way to make it work.
I made this change, but I'm not going to make the `QuotaInfo` rename since we already have a `xfs::QuotaInfo` type. > On Aug. 24, 2018, 11:38 p.m., Chun-Hung Hsiao wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 476 (patched) > > <https://reviews.apache.org/r/68401/diff/1/?file=2074210#file2074210line497> > > > > Don't we have the same problem for ROOT and PATH disks (w/ or w/o > > `root`)? Or is the assumption here that the operator must ensure that all > > ROOT and PATH disks are on XFS? > > > > Is there a way to check if the sandbox and persistent volumes are on > > XFS, and set the quota only for those that are on XFS? Added a check to enforce that PATH volumes must have XFS project quotas enabled. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review207915 ----------------------------------------------------------- On Sept. 10, 2018, 9:34 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68401/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2018, 9:34 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, > and Jiang Yan Xu. > > > Bugs: MESOS-5158 > https://issues.apache.org/jira/browse/MESOS-5158 > > > Repository: mesos > > > Description > ------- > > Added persistent volume support to the `disk/xfs` isolator. This > implementation largely tracks the `disk/du` implementation in that > we now keep a map of paths in each container info structure. We now > defer quota clean up to project ID reclaimation time so that we can > use the same mechanism for sandbox and persistent volume paths. > > We explicitly exclude mount disks from XFS project quotas, but we still > track them so that we can correctly publish their usage information in > the container `DiskStatistics` message. This means that mount disks are > not required to be XFS filesystems or have project quotas configured. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 38c467b47cb7c04803b0709b8239458fb26abb61 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 783da0407528c044035d18cc59a744353921d64c > src/tests/containerizer/xfs_quota_tests.cpp > 2b3a2e25f5075357f090d47826698e7bb6fdf969 > > > Diff: https://reviews.apache.org/r/68401/diff/4/ > > > Testing > ------- > > sudo make check (Fedora 28) > > > Thanks, > > James Peach > >
