> On Sept. 20, 2018, 12:59 a.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > > Lines 83 (patched) > > <https://reviews.apache.org/r/68401/diff/4/?file=2087665#file2087665line83> > > > > Nit: `const`?
Fixed. > On Sept. 20, 2018, 12:59 a.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > > Lines 87 (patched) > > <https://reviews.apache.org/r/68401/diff/4/?file=2087665#file2087665line87> > > > > Nit: We can use parameter names without underscores here - there's no > > shadowing. Also, `explicit`? Unless we want to use `= {dir, projid}` for it > > :) > Nit: We can use parameter names without underscores here - there's no > shadowing Agreed. > Also, explicit? Unless we want to use = {dir, projid} for it :) The previous `explicit` was a holdover from when the constructor took only a single argument. I don't think we still need `explicit` since there aren't any implicit conversions. > On Sept. 20, 2018, 12:59 a.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 416 (original), 585-587 (patched) > > <https://reviews.apache.org/r/68401/diff/4/?file=2087666#file2087666line611> > > > > Funny how in a case where a volume is shared by multiple containers we > > can kill all of them because of a single offender. Just thinking out loud. > > Probably worth noting that in the docs. Yeh, IIRC the `disk/du` isolator has the same behaviour. Maybe returning a write failure makes more sense for persistent volumes. We could revisit that, though I would be concerned by the extra complexity. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review208778 ----------------------------------------------------------- On Sept. 10, 2018, 9:34 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68401/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2018, 9:34 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, > and Jiang Yan Xu. > > > Bugs: MESOS-5158 > https://issues.apache.org/jira/browse/MESOS-5158 > > > Repository: mesos > > > Description > ------- > > Added persistent volume support to the `disk/xfs` isolator. This > implementation largely tracks the `disk/du` implementation in that > we now keep a map of paths in each container info structure. We now > defer quota clean up to project ID reclaimation time so that we can > use the same mechanism for sandbox and persistent volume paths. > > We explicitly exclude mount disks from XFS project quotas, but we still > track them so that we can correctly publish their usage information in > the container `DiskStatistics` message. This means that mount disks are > not required to be XFS filesystems or have project quotas configured. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 07e68a777aefba4dd35066f2eb207bba7f199d83 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 2113f8665e4e84bdf12868f605b480522816a9ba > src/tests/containerizer/xfs_quota_tests.cpp > 11dc7f596671d373cd0c9b443a1d217053285a63 > > > Diff: https://reviews.apache.org/r/68401/diff/5/ > > > Testing > ------- > > sudo make check (Fedora 28) > > > Thanks, > > James Peach > >
