> On Sept. 19, 2018, 1:12 p.m., Benjamin Bannier wrote: > > src/tests/agent_resource_provider_config_api_tests.cpp > > Lines 508-511 (patched) > > <https://reviews.apache.org/r/68758/diff/1/?file=2090232#file2090232line508> > > > > We don't seem to explicitly need this here. Is this something we could > > change in the fixture instead?
Fixed in r/68777. > On Sept. 19, 2018, 1:12 p.m., Benjamin Bannier wrote: > > src/tests/agent_resource_provider_config_api_tests.cpp > > Lines 826 (patched) > > <https://reviews.apache.org/r/68758/diff/1/?file=2090232#file2090232line826> > > > > Can and should we also check that existing RP is not terminated? We can manipulate the clock similar to the `*Idempotent` tests, but I feel it a bit unnecessary here since that would make the test less concise and we already checked that the file doesn't change. If you still think we should do the check I can do that. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/#review208762 ----------------------------------------------------------- On Sept. 19, 2018, 4:50 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68758/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2018, 4:50 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9228 > https://issues.apache.org/jira/browse/MESOS-9228 > > > Repository: mesos > > > Description > ------- > > Added unit tests for adding/updating invalid resource provider configs. > > > Diffs > ----- > > src/tests/agent_resource_provider_config_api_tests.cpp > e6a68bae1a9e3e773ea45deae4951664ab81a857 > > > Diff: https://reviews.apache.org/r/68758/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
